Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 28, 2010, 16:27 UTC
- Message-ID
- <20101128162720.GB18335@burratino>
- In-Reply-To
- <20101128081048.13668.67286.reportbug@sb74.startrek>
Hi Jakub et al,
Daniel Reichelt wrote[1]:
Show 11 quoted lines
> I just noticed that integrating gitweb via reverse proxy is impossible when
> path_info is enabled in gitweb.conf. The base href sent on gitweb.cgi:3427
> contains the "internal" URL called by the reverse proxy mechanism, not the
> original one called by the user agent which makes it impossible for the
> client to display CSS, images, etc...
>
> I suggest an additional config variable, e.g.
> $feature{'pathinfo'}{'basehrefoverride'} which could override the base href
> tag determinted by the cgi script (or disable sending a base href tag at all
> - at least I was able to achieve my desired setup by adjusting the URLs for
> CSS etc in gitweb.conf to fitting absolute URLs).Any advice for Daniel? Is it a good idea?
Regards, Jonathan
[1] http://bugs.debian.org/605217