Re: [PATCH v2/RFC] Make git-completion Bash 4 compatible.

From: Peter van der Does <peter@avirtualhome.com>
Date: Oct 28, 2010, 12:14 UTC
Message-ID: <20101028081445.27cc603b@MonteCarlo>
In-Reply-To: <20101028005455.GC31501@burratino>

On Wed, 27 Oct 2010 19:54:55 -0500 Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 6 quoted lines

> Peter van der Does wrote:
> 
> > The bash completion script could still be included with the core,
> > but we can offer different versions for different shells.
> 
> Why?  That's three times the maintenance work.

The cons of everything in one script:
- If the script needs an update the submitter has to take in account
  the different coding standards each shell has. Examples of this have
  been given in the commit message of 06f44c3 (completion: make
  compatible with zsh, 2010-09-06)

- The script could end up with a slew of if statements to see which
  shell the script is running in and taking some action.

- Shells don't share all the same functions, the script could be filled
  with functions not needed in other shells. the zsh patch includes
  one, the Bash 4 patch includes several.

The pros of everything in one script:
- Small changes, like adding an extra option to a git command for
  completion only have to implemented in one script.

The maintenance of the various scripts would be done by people who have a full understanding of the shell for which the script is written for. I kind of see this suggestion as building the git package for a Linux distribution, Windows or Mac. Debian and Ubuntu have some patches that are not included in the core to make git work better on those distributions. The maintenance is done by the people who have in depth knowledge of that distribution.

-- 
Peter van der Does

GPG key: E77E8E98

IRC: Ganseki on irc.freenode.net
Twitter: @petervanderdoes