Re: [PATCH v2/RFC] Make git-completion Bash 4 compatible.

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Oct 27, 2010, 22:53 UTC
Message-ID: <20101027225318.GB1877@neumann>
In-Reply-To: <20101027173132.GA15657@burratino>

Hi Jonathan,

On Wed, Oct 27, 2010 at 12:31:32PM -0500, Jonathan Nieder wrote:

> Could some zsh user perhaps test that the new zsh support is not
> broken?

I'm afraid it is.

The commit message of 06f44c3 (completion: make compatible with zsh, 2010-09-06) says:

    ${var:2}
        Zsh does not implement ${var:2} to skip the first 2 characters, but
        ${var#??} works in both shells to replace the first 2 characters
        with nothing.  Thanks to Jonathan Nieder for the suggestion.

    for (( n=1; "$n" ... ))
        Zsh does not allow "$var" in arithmetic loops.  Instead, pre-compute
        the endpoint and use the variables without $'s or quotes.

However, the functions taken over from the bash-completion code contain constructs like:

    ${cur:0:$index}
    # ok, this is not exactly the same as ${var:2}, so it might even
    # work...

and

    for (( i=0, j=0; i < ${#COMP_WORDS[@]}; i++, j++)); do

But I haven't actually tried it.

Best, Gábor