Re: [PATCHv4 05/21] notes.h/c: Clarify the handling of notes objects that are == null_sha1

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 21, 2010, 17:54 UTC
Message-ID: <20101021175404.GC11328@burratino>
In-Reply-To: <201010211513.06176.johan@herland.net>

Johan Herland wrote:

Show 5 quoted lines

>   Allow combine_notes functions to request that a note be removed,
>   by setting the resulting note SHA1 to null_sha1 (0000000...).
> 
>   For consistency, also teach note_tree_insert() to skip insertion
>   of an empty note when there is no note to combine it with.

I guess it's probably also worth clarifying that the term "empty note" means null_sha1 rather than empty_blob_sha1.

i.e. something like:

	For consistency, also teach note_tree_insert() to skip insertion
	of an empty note (a note with val_sha1 equal to null_sha1)
	when there is no note to combine it with.

The previous behavior iiuc would have been for write_notes_tree() to write invalid trees after such an operation.