git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t5523: test push progress output to tty

From
JKJeff King <jrk@wrek.org>
Date
Oct 14, 2010, 03:34 UTC
Message-ID
<20101014033448.GB28197@sigill.intra.peff.net>
In-Reply-To
<20101014031642.GB14664@burratino>
On Wed, Oct 13, 2010 at 10:16:42PM -0500, Jonathan Nieder wrote:
Show 19 quoted lines
> Jeff King wrote:
> 
> > --- a/t/t5523-push-upstream.sh
> > +++ b/t/t5523-push-upstream.sh
> [...]
> > @@ -72,7 +73,14 @@ test_expect_success 'push -u HEAD' '
> >  	check_config headbranch upstream refs/heads/headbranch
> >  '
> >  
> > -test_expect_success 'progress messages to non-tty' '
> > +test_expect_success 'progress messages go to tty' '
> > +	ensure_fresh_upstream &&
> > +
> > +	test_terminal git push -u upstream master >out 2>err &&
> > +	grep "Writing objects" err
> > +'
> 
> Missing TTY prerequisite.  (Do you think test_terminal should check
> $prereq to prevent this?)

Oops, good catch. I think we should already catch it, as test_terminal will not be defined at all in the no-tty case. We could print a nicer message, but it is not likely to be seen by the user. If they are using "-v", then stderr probably _is_ a tty. And if not, they will not see the message. There are ways around it, but they are not likely to be seen unless the user is really trying (e.g., "./t5523-* -v >not_a_tty").

-Peff
Previous: Jonathan NiederNext: Jonathan Nieder
Message 34 of 41 in “Fix to push --progress. The --progress flag was not being passed into tranport.c from send-pack.h, making the --progress flag unusable”
  1. Fix to push --progress. The --progress flag was not being passed into tranport.c from send-pack.h, making the --progress flag unusableChase Brammer, Oct 12, 2010
  2. Jonathan NiederOct 12, 2010
  3. Junio C HamanoOct 13, 2010
  4. Jeff KingOct 13, 2010
  5. Tay Ray ChuanOct 13, 2010
  6. 0/3 fix push --progress over file://, git://, etc.Tay Ray Chuan, Oct 13, 2010
  7. 1/3 t5523-push-upstream: add function to ensure fresh upstream repoTay Ray Chuan, Oct 13, 2010
  8. Jonathan NiederOct 13, 2010
  9. 2/3 t5523-push-upstream: test progress messagesTay Ray Chuan, Oct 13, 2010
  10. 3/3 push: pass --progress down to git-pack-objectsTay Ray Chuan, Oct 13, 2010
  11. Tay Ray ChuanOct 14, 2010
  12. Jeff KingOct 14, 2010
  13. Tay Ray ChuanOct 13, 2010
  14. 0/8 fix push --progress over file://, git://, etc.Tay Ray Chuan, Oct 16, 2010
  15. 1/8 tests: factor out terminal handling from t7006Tay Ray Chuan, Oct 16, 2010
  16. 2/8 tests: test terminal output to both stdout and stderrTay Ray Chuan, Oct 16, 2010
  17. 3/8 test-lib: allow test code to check the list of declared prerequisitesTay Ray Chuan, Oct 16, 2010
  18. 4/8 test_terminal: catch use without TTY prerequisiteTay Ray Chuan, Oct 16, 2010
  19. 5/8 test_terminal: give priority to test-terminal.perl usageTay Ray Chuan, Oct 16, 2010
  20. 6/8 t5523-push-upstream: add function to ensure fresh upstream repoTay Ray Chuan, Oct 16, 2010
  21. 7/8 t5523-push-upstream: test progress messagesTay Ray Chuan, Oct 16, 2010
  22. 8/8 push: pass --progress down to git-pack-objectsTay Ray Chuan, Oct 16, 2010
  23. Jonathan NiederOct 17, 2010
  24. Jonathan NiederOct 17, 2010
  25. Jeff KingOct 22, 2010
  26. Jonathan NiederOct 17, 2010
  27. 0/3 more push progress testsJeff King, Oct 14, 2010
  28. 1/3 tests: factor out terminal handling from t7006Jeff King, Oct 14, 2010
  29. Jonathan NiederOct 14, 2010
  30. 2/3 tests: test terminal output to both stdout and stderrJeff King, Oct 14, 2010
  31. Jonathan NiederOct 14, 2010
  32. 3/3 t5523: test push progress output to ttyJeff King, Oct 14, 2010
  33. Jonathan NiederOct 14, 2010
  34. Jeff KingOct 14, 2010
  35. 0/2 test_terminal: check that TTY prerequisite is declaredJonathan Nieder, Oct 14, 2010
  36. 1/2 test-lib: allow test code to check the list of declared prerequisitesJonathan Nieder, Oct 14, 2010
  37. Ævar Arnfjörð BjarmasonOct 15, 2010
  38. Jonathan NiederOct 15, 2010
  39. 2/2 test_terminal: catch use without TTY prerequisiteJonathan Nieder, Oct 14, 2010
  40. Jeff KingOct 15, 2010
  41. Tay Ray ChuanOct 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.