Re: [PATCH] Fix to push --progress. The --progress flag was not being passed into tranport.c from send-pack.h, making the --progress flag unusable
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 12, 2010, 22:44 UTC
- Message-ID
- <20101012224456.GC15587@burratino>
- In-Reply-To
- <AANLkTin9_kofdy49WF4V_JoovVR+G8DN7vn-cz3p84fz@mail.gmail.com>
Chase Brammer wrote:
> The result of this is external tools and tools writing standard error > to a file from bash would not be able to receive progress information > during a push. Similar functionality is seen in fetch, which still > works.
A bit of protocol: since the patch is by Jeff, this should have
From: Jeff King <peff@peff.net>
at the beginning of the log message. See Documentation/SubmittingPatches for details.
> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
I didn't help. :)
> builtin/send-pack.c | 3 +++ > send-pack.h | 1 + > transport.c | 1 + > 3 files changed, 5 insertions(+), 0 deletions(-)
It's not necessary by any means, but it would be nice to add a test for this to t/ so no one breaks the new functionality in the future.
Thanks.