Re: [PATCH 5/7] vcs-svn: extend svndump to parse version 3 format
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 12, 2010, 22:56 UTC
- Message-ID
- <20101012225646.GF15587@burratino>
- In-Reply-To
- <1286891424-2067-6-git-send-email-david.barr@cordelta.com>
David Barr wrote:
> Added 1 new dump header, SVN-fs-dump-format-version. > Added 6 new node headers:
Style: using the imperative mood, present tense would make this fit better with other log entries.
Show 8 quoted lines
> --- a/vcs-svn/svndump.c > +++ b/vcs-svn/svndump.c > @@ -27,6 +27,9 @@ > #define LENGTH_UNKNOWN (~0) > #define DATE_RFC2822_LEN 31 > > +#define MD5_HEX_LENGTH 32 > +#define SHA1_HEX_LENGTH 40
I was surprised to find this is not in any existing header. Looks good to me.