Re: [PATCH 1/7] Teach fast-import to print the id of each imported commit

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 12, 2010, 22:06 UTC
Message-ID: <20101012220625.GA15587@burratino>
In-Reply-To: <1286891424-2067-2-git-send-email-david.barr@cordelta.com>

David Barr wrote:

Show 10 quoted lines

> --- a/Documentation/git-fast-import.txt
> +++ b/Documentation/git-fast-import.txt
> @@ -92,6 +92,18 @@ OPTIONS
>  	--(no-)-relative-marks= with the --(import|export)-marks=
>  	options.
>  
> +--report-fd=<fd>::
> +	Print the 40-character object name for each commit to
> +	the specified file descriptor before writing it to the
> +	pack.

This aspect (the printing of commit ids) of the report-fd feature is not used by the current svn-fe3 code. I'd suggest dropping it or at least making it optional; marks work pretty well for that purpose and it is not worth the cost or complication of making the frontend synchronize with fast-import with every commit.

Show 8 quoted lines

> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -361,6 +361,9 @@ static uintmax_t next_mark;
>  static struct strbuf new_data = STRBUF_INIT;
>  static int seen_data_command;
>  
> +/* Where to report commits */
> +static int report_fd = -1;

This aspect is still useful (for use by the cat command). :)

Thanks.