git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] Add bidirectional_transfer_loop()

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Sep 30, 2010, 13:55 UTC
Message-ID
<20100930135502.GG4850@burratino>
In-Reply-To
<1285847579-21954-2-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara wrote:
> --- a/transport-helper.c
> +++ b/transport-helper.c
[...]
> +	if (!in_hup && inbufuse < BUFFERSIZE) {
> +		stdin_index = nextindex++;
> +		polls[stdin_index].fd = 0;
> +		transfer_debug("Adding stdin to fds to wait for");
Why not:
		trace_printf("trace: adding stdin to ...");

? That would give the user control of where tracing output goes (settings like GIT_TRACE=17).

If trace is too noisy (I don't think it is), maybe we should make it more nuanced, like GIT_TRACE=17:transport?

Previous: Ilari LiusvaaraNext: Ilari Liusvaara
Message 3 of 13 in “git-remote-fd & git-remote-ext”
  1. 0/3 git-remote-fd & git-remote-extIlari Liusvaara, Sep 30, 2010
  2. 1/3 Add bidirectional_transfer_loop()Ilari Liusvaara, Sep 30, 2010
  3. Jonathan NiederSep 30, 2010
  4. Ilari LiusvaaraSep 30, 2010
  5. Jonathan NiederSep 30, 2010
  6. 2/3 git-remote-fdIlari Liusvaara, Sep 30, 2010
  7. Ævar Arnfjörð BjarmasonSep 30, 2010
  8. Jonathan NiederSep 30, 2010
  9. Ilari LiusvaaraSep 30, 2010
  10. 3/3 git-remote-extIlari Liusvaara, Sep 30, 2010
  11. Jonathan NiederSep 30, 2010
  12. Junio C HamanoSep 30, 2010
  13. Jonathan NiederOct 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.