From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 30 Sep 2010 13:55:02 GMT
Subject: Re: [PATCH v2 1/3] Add bidirectional_transfer_loop()
Message-ID: <20100930135502.GG4850@burratino>
In-Reply-To: <1285847579-21954-2-git-send-email-ilari.liusvaara@elisanet.fi>

Ilari Liusvaara wrote:

> --- a/transport-helper.c
> +++ b/transport-helper.c
[...]
> +	if (!in_hup && inbufuse < BUFFERSIZE) {
> +		stdin_index = nextindex++;
> +		polls[stdin_index].fd = 0;
> +		transfer_debug("Adding stdin to fds to wait for");

Why not:

		trace_printf("trace: adding stdin to ...");

?  That would give the user control of where tracing output goes
(settings like GIT_TRACE=17).

If trace is too noisy (I don't think it is), maybe we should
make it more nuanced, like GIT_TRACE=17:transport?