git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/3] tests: Prepare --textconv tests for correctly-failing conversion program

From
Jeff King <peff@peff.net>
Date
Sep 28, 2010, 14:39 UTC
Message-ID
<20100928143928.GA8918@sigill.intra.peff.net>
In-Reply-To
<20100928143540.GA30357@landau.phys.spbu.ru>
On Tue, Sep 28, 2010 at 06:35:40PM +0400, Kirill Smelkov wrote:
Show 7 quoted lines
> > >  t/t4042-diff-textconv-caching.sh |    4 ++--
> > 
> > Why are we touching t4042 at all in this series? We are not actually
> > adding any tests to it, AFAICT.
> 
> Because we want to catch potential wrong textconv invocation on non
> "bin: " files there too?

But we don't actually add any tests that display the problem there, do we? And even if we wanted to test the diff implementation, wouldn't t4030 be the write place to do that? t4042 is specifically about textconv caching.

-Peff
Previous: Kirill SmelkovNext: Kirill Smelkov
Message 9 of 18 in “Fix {blame,cat-file} --textconv for cases with symlinks”
  1. 0/3 Fix {blame,cat-file} --textconv for cases with symlinksKirill Smelkov, Sep 24, 2010
  2. 1/3 tests: Prepare --textconv tests for correctly-failing conversion programKirill Smelkov, Sep 24, 2010
  3. Junio C HamanoSep 27, 2010
  4. Kirill SmelkovSep 28, 2010
  5. Kirill SmelkovSep 28, 2010
  6. Kirill SmelkovSep 28, 2010
  7. Jeff KingSep 28, 2010
  8. Kirill SmelkovSep 28, 2010
  9. Jeff KingSep 28, 2010
  10. Kirill SmelkovSep 28, 2010
  11. Junio C HamanoSep 28, 2010
  12. Jeff KingSep 28, 2010
  13. Kirill SmelkovSep 28, 2010
  14. Kirill SmelkovSep 29, 2010
  15. 2/3 blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinksKirill Smelkov, Sep 24, 2010
  16. Junio C HamanoSep 27, 2010
  17. Kirill SmelkovSep 28, 2010
  18. 3/3 blame,cat-file --textconv: Don't assume mode is ``S_IFREF | 0664''Kirill Smelkov, Sep 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.