From: Jeff King <peff@peff.net>
Date: Tue, 28 Sep 2010 14:39:28 GMT
Subject: Re: [PATCH v3 1/3] tests: Prepare --textconv tests for correctly-failing conversion program
Message-ID: <20100928143928.GA8918@sigill.intra.peff.net>
In-Reply-To: <20100928143540.GA30357@landau.phys.spbu.ru>

On Tue, Sep 28, 2010 at 06:35:40PM +0400, Kirill Smelkov wrote:

> > >  t/t4042-diff-textconv-caching.sh |    4 ++--
> > 
> > Why are we touching t4042 at all in this series? We are not actually
> > adding any tests to it, AFAICT.
> 
> Because we want to catch potential wrong textconv invocation on non
> "bin: " files there too?

But we don't actually add any tests that display the problem there, do
we? And even if we wanted to test the diff implementation, wouldn't
t4030 be the write place to do that? t4042 is specifically about
textconv caching.

-Peff