git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 05/17] Documentation: add missing quotes to "git grep" examples

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 20, 2010, 10:28 UTC
Message-ID
<20100820102853.GE10407@burratino>
In-Reply-To
<20100820101902.GA10356@burratino>

Without an indication to the contrary, Asciidoc puts 'quoted text' in italics, making the output look like this:

	git grep time_t -- *.[ch]
	    Looks for time_t in all tracked .c and .h
	    files in the working directory and its subdirectories.
	git grep -e '#define\' --and \( -e MAX_PATH -e PATH_MAX \)
	    Looks for a line that has #define and either MAX_PATH or
	    PATH_MAX.

In the first example, the *.[ch] argument needs to be protected from the shell, or else it will only match files in the current directory. The second example has a stray backslash.

Reported-by: Frédéric Brière <fbriere@fbriere.net>
Cc: Mark Lodato <lodatom@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 Documentation/git-grep.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
index 5474dd7..dab0a78 100644
--- a/Documentation/git-grep.txt
+++ b/Documentation/git-grep.txt
@@ -191,11 +191,11 @@ OPTIONS
 Examples
 --------
 
-git grep 'time_t' \-- '*.[ch]'::
+git grep {apostrophe}time_t{apostrophe} \-- {apostrophe}*.[ch]{apostrophe}::
 	Looks for `time_t` in all tracked .c and .h files in the working
 	directory and its subdirectories.
 
-git grep -e \'#define\' --and \( -e MAX_PATH -e PATH_MAX \)::
+git grep -e {apostrophe}#define{apostrophe} --and \( -e MAX_PATH -e PATH_MAX \)::
 	Looks for a line that has `#define` and either `MAX_PATH` or
 	`PATH_MAX`.
 
-- 
1.7.2.2.536.g42dab.dirty
Previous: Jonathan NiederNext: Jonathan Nieder
Message 6 of 22 in “unexpected backslashes in man pages”
  1. 00/17 unexpected backslashes in man pagesJonathan Nieder, Aug 20, 2010
  2. 01/17 Documentation: tweak description of log.dateJonathan Nieder, Aug 20, 2010
  3. 02/17 Documentation: quoting trouble in "git rm" discussionJonathan Nieder, Aug 20, 2010
  4. 03/17 Documentation: unbreak regex in show-ref manualJonathan Nieder, Aug 20, 2010
  5. 04/17 Documentation: clarify quoting in "git add" exampleJonathan Nieder, Aug 20, 2010
  6. 05/17 Documentation: add missing quotes to "git grep" examplesJonathan Nieder, Aug 20, 2010
  7. 06/17 Documentation: clarify quoting in "git rm" exampleJonathan Nieder, Aug 20, 2010
  8. 07/17 Documentation: clarify quoting in gitignore docsJonathan Nieder, Aug 20, 2010
  9. 08/17 Documentation: remove backslashes in manpage synopsesJonathan Nieder, Aug 20, 2010
  10. 09/17 Documentation/technical: avoid stray backslash in parse-options API docsJonathan Nieder, Aug 20, 2010
  11. 10/17 Documentation: remove stray backslash from "git bundle" manualJonathan Nieder, Aug 20, 2010
  12. 11/17 Documentation: remove backslash before ~ in fast-import manualJonathan Nieder, Aug 20, 2010
  13. 12/17 Documentation: remove stray backslashes in rev-parse manualJonathan Nieder, Aug 20, 2010
  14. 13/17 Documentation: remove stray backslash in show-branch discussionJonathan Nieder, Aug 20, 2010
  15. Thomas RastAug 23, 2010
  16. Ramkumar RamachandraAug 23, 2010
  17. Jonathan NiederAug 23, 2010
  18. 14/17 Documentation: avoid stray backslashes in core tutorialJonathan Nieder, Aug 20, 2010
  19. 15/17 Documentation: avoid stray backslash in user manualJonathan Nieder, Aug 20, 2010
  20. 16/17 Documentation: do not convert ... operator to ellipsesJonathan Nieder, Aug 20, 2010
  21. 17/17 Documentation: remove stray backslashes from "Fighting regressions" articleJonathan Nieder, Aug 20, 2010
  22. Thomas RastAug 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.