git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH il/rfc-remote-fd-ext] Fix build on Windows

From
ILIlari Liusvaara <ilari.liusvaara@elisanet.fi>
Date
Aug 14, 2010, 09:38 UTC
Message-ID
<20100814093801.GA28522@LK-Perkele-V2.elisa-laajakaista.fi>
In-Reply-To
<201008140009.19291.j6t@kdbg.org>
On Sat, Aug 14, 2010 at 12:09:19AM +0200, Johannes Sixt wrote:
> This adds the necessary #defines so that the programs can be built, but
> since the poll emulation is not extended to support POLLOUT and POLLNVAL,
> the resulting programs will most likely not function properly. (The test
> does not check them, yet.)

The code doesn't really need POLLNVAL (Its just there for "can't happen" case). POLLOUT is needed. I looked at poll emulation code: It returning EINVAL causes transfer loop to fail quick.

I think its possible to write the loop in terms of select instead of poll. Would this be better for Git on Windows?

-Ilari
Previous: Johannes SixtNext: Johannes Sixt
Message 2 of 3 in “Fix build on Windows”
  1. Fix build on WindowsJohannes Sixt, Aug 13, 2010
  2. Ilari LiusvaaraAug 14, 2010
  3. Johannes SixtAug 14, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.