From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Sat, 14 Aug 2010 09:38:01 GMT
Subject: Re: [PATCH il/rfc-remote-fd-ext] Fix build on Windows
Message-ID: <20100814093801.GA28522@LK-Perkele-V2.elisa-laajakaista.fi>
In-Reply-To: <201008140009.19291.j6t@kdbg.org>

On Sat, Aug 14, 2010 at 12:09:19AM +0200, Johannes Sixt wrote:
> This adds the necessary #defines so that the programs can be built, but
> since the poll emulation is not extended to support POLLOUT and POLLNVAL,
> the resulting programs will most likely not function properly. (The test
> does not check them, yet.)

The code doesn't really need POLLNVAL (Its just there for "can't happen"
case). POLLOUT is needed. I looked at poll emulation code: It returning
EINVAL causes transfer loop to fail quick.

I think its possible to write the loop in terms of select instead of poll.
Would this be better for Git on Windows?

-Ilari