Re: remove duplicate code and not needed break statement

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 19, 2010, 16:06 UTC
Message-ID: <20100719160632.GA17526@burratino>
In-Reply-To: <AANLkTimHHJnvgFh3Kd7jMqTJJFensZjkD7YCU1gdt-FT@mail.gmail.com>

Hi Erik,

Erik Faye-Lund wrote:

> On Sun, Jul 18, 2010 at 7:49 PM, Ralf Thielow

Show 7 quoted lines

>>                case 'D': /* we used to emit D but that was misguided. */
>> -                       goto out_stale;
>> -                       break;
>>                case 'T': /* we used to emit T but nobody uses it. */
>
> We have a tendency of adding a comment pointing out fall through
> between case-statements. Perhaps you should add one?

I think in this case that would not be appropriate. It is the difference between:

	case 1:
	case 2:
	case 3:
		puts("one to three");
		break;

and

	case 1:
		puts("one");
		/* fall through */
	case 2:
	case 3:
		puts("one to three");
		break;

I admit, I am surprised to see multiple suggestions for improvements to details of the patch. I guess I should say, except for the log message, it is

  Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

i.e., I don’t see any low-hanging fruit for improving it without actually taking a deeper look at the surrounding code. Ralf, can we have your sign-off? That way maybe it could be applied and people could suggest patches on top.

Still, thanks for looking it over.

Jonathan