git/list[1] front-page[2] threads[3] people[4] search[5] about
 

remove duplicate code and not needed break statement

From
Ralf Thielow <ralf.thielow@googlemail.com>
Date
Jul 18, 2010, 17:49 UTC
Message-ID
<1279475399-6081-1-git-send-email-ralf.thielow@googlemail.com>
Remove duplicate code and not needed break statement.

On switch statements you can use multiple cases for one statement and on a goto statement you not need a break.

>From 5b3e7c8f8b81a295b5c58534be250f5a818ccc64 Mon Sep 17 00:00:00 2001
From: Ralf Thielow <ralf.thielow@googlemail.com>
Date: Sun, 18 Jul 2010 18:48:58 +0200
Subject: [PATCH] remove duplicate code and not needed break statement
---
 server-info.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/server-info.c b/server-info.c
index 4098ca2..9ec744e 100644
--- a/server-info.c
+++ b/server-info.c
@@ -113,11 +113,8 @@ static int read_pack_info_file(const char *infofile)
 				goto out_stale;
 			break;
 		case 'D': /* we used to emit D but that was misguided. */
-			goto out_stale;
-			break;
 		case 'T': /* we used to emit T but nobody uses it. */
 			goto out_stale;
-			break;
 		default:
 			error("unrecognized: %s", line);
 			break;
Next: Valeo de Vries
Message 1 of 9 in “remove duplicate code and not needed break statement”
  1. Ralf ThielowJul 18, 2010
  2. Valeo de VriesJul 18, 2010
  3. Ralf ThielowJul 18, 2010
  4. Jonathan NiederJul 18, 2010
  5. Ralf ThielowJul 18, 2010
  6. Erik Faye-LundJul 19, 2010
  7. Jonathan NiederJul 19, 2010
  8. Ralf ThielowJul 19, 2010
  9. Ralf ThielowJul 18, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.