Re: [RFC/PATCH 1/4] gitweb: Move subroutines to Gitweb::Config module
- From
Petr Baudis <pasky@suse.cz>
- Date
- Jun 8, 2010, 20:50 UTC
- Message-ID
- <20100608205029.GB3408@machine.or.cz>
- In-Reply-To
- <AANLkTimKsdn8Vww_4U4YQDPlpr_BgbVszwG64lEYl-cE@mail.gmail.com>
On Wed, Jun 09, 2010 at 01:54:34AM +0530, Pavan Kumar Sunkara wrote:
Show 7 quoted lines
> On Wed, Jun 9, 2010 at 1:25 AM, Petr Baudis <pasky@suse.cz> wrote: > > On Wed, Jun 09, 2010 at 12:52:11AM +0530, Pavan Kumar Sunkara wrote: > >> Gitweb::Parse > > > > What will this module do? > > This module contains all the parse_* subroutines
Ok, that makes sense. It might be also possible to have them in Gitweb::Git, but I see href() invocations and such that would probably create layering violations.
> Gitweb::Format contains all the format_* subroutines
Here, I'm less decided. I would have put these in Gitweb::HTML, but I have no hard opinion, maybe that's clumping things too much - so no nack from me personally.
Show 5 quoted lines
> >> Gitweb::Util > > > > What will this module do? > > This modules contains all the git utility functions.
Can you give an example, please?
> I still have until this week in the timeline. Don't I ? > I strongly hope that I will be able to finalise the patch queue by > this week and will move on to develop write functionalities.
Sure, my only concern is that if the queue of patches your future work will depend on gets too long and gets delayed too much in merging in, it will get much more difficult to produce further patches, get them reviewed and get them on the merging track.
-- Petr "Pasky" Baudis The true meaning of life is to plant a tree under whose shade you will never sit.