git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 1/4] gitweb: Move subroutines to Gitweb::Config module

From
Petr Baudis <pasky@suse.cz>
Date
Jun 8, 2010, 19:55 UTC
Message-ID
<20100608195552.GA3408@machine.or.cz>
In-Reply-To
<AANLkTiksOpUqxGc7Lo4clrLwOF6GvkT7CZH5CVeirtBr@mail.gmail.com>
On Wed, Jun 09, 2010 at 12:52:11AM +0530, Pavan Kumar Sunkara wrote:
> I am graining Gitweb::HTML into Gitweb::HTML::* to reduce circular
> dependancies of the modules.

I'm sorry, I don't understand. How is splitting up Gitweb::HTML to submodules helping to reduce circular dependencies? I don't quite see that right now. :-( Can you give a concrete example? Perhaps it would be better to refactor the few problematic users instead of convoluting the whole module structure because of the offenders.

>   Gitweb::Parse
What will this module do?
>   Gitweb::Util
What will this module do?
>   Gitweb::Action::* (All action subs like git_blame, git_log)

Do we need to do this right now? I think moving huge chunks of the code around like this right now is unneccessary and it might just enlarge the patch queue and delay you in your main GSoC efforts; perhaps we could do this later when the dust settles a bit and we are sure that the rest of the modular structure we have introduced fits well?

> I will be rebasing the whole series, edit them and send them once
> every module has undergone as RFC in the mailing list.
Ok! I have meant to ask about that.
Show 6 quoted lines
> I have been stuck many times trying to workaround the circular module
> dependancies and believe me, the patches I am sending and the modules
> I am creating involves a lot of effort from my side and as long as you
> think there's nothing wrong with the grouping of subroutines in my
> modules and their names, you need not worry about the module
> structure.

I'm sorry but it doesn't work like that - if you have put a lot of effort behind it, you need to present us with the rationale you have reached and convince us that this is the right way to take.

-- 
				Petr "Pasky" Baudis
The true meaning of life is to plant a tree under whose shade
you will never sit.
Previous: Pavan Kumar SunkaraNext: Pavan Kumar Sunkara
Message 13 of 17 in “gitweb: Move subroutines to Gitweb::Config module”
  1. 1/4 gitweb: Move subroutines to Gitweb::Config modulePavan Kumar Sunkara, Jun 7, 2010
  2. 2/4 gitweb: Create Gitweb::HTML::Link modulePavan Kumar Sunkara, Jun 7, 2010
  3. 3/4 gitweb: Create Gitweb::HTML modulePavan Kumar Sunkara, Jun 7, 2010
  4. 4/4 gitweb: Create Gitweb::HTML::String modulePavan Kumar Sunkara, Jun 7, 2010
  5. Pavan Kumar SunkaraJun 7, 2010
  6. Jakub NarebskiJun 8, 2010
  7. Ævar Arnfjörð BjarmasonJun 8, 2010
  8. Jakub NarebskiJun 12, 2010
  9. Ævar Arnfjörð BjarmasonJun 12, 2010
  10. Jakub NarebskiJun 12, 2010
  11. Petr BaudisJun 8, 2010
  12. Pavan Kumar SunkaraJun 8, 2010
  13. Petr BaudisJun 8, 2010
  14. Pavan Kumar SunkaraJun 8, 2010
  15. Petr BaudisJun 8, 2010
  16. Jakub NarebskiJun 8, 2010
  17. Jakub NarebskiJun 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.