Re: [PATCH/RFC v7 1/2] Add infrastructure for translating Git with gettext

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 5, 2010, 03:38 UTC
Message-ID: <20100605033849.GB2252@progeny.tock>
In-Reply-To: <AANLkTilSJ_1STKGvat0llqYVZRI8_tQriE-hIBJPEldn@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> On Sat, Jun 5, 2010 at 03:01, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 15 quoted lines

>>  #ifdef NO_GETTEXT
>>  static inline void git_setup_gettext(void) {}
>>  #endif
>>
>> and
>>
>>  ifndef NO_GETTEXT
>>  LIB_OBJS += gettext.o
>>  endif
>
> Sure, but that would be putting code in a header file, which is
> usually taboo. It looks like there's some prior art on that though.
> Like strbuf.h.
> 
> I don't care either way, what do you think?

This is what ‘inline’ is for. I think using it for stubs like this is perfectly acceptable and improves readability.

Jonathan