Re: [PATCH/RFC v7 1/2] Add infrastructure for translating Git with gettext
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 5, 2010, 03:36 UTC
- Message-ID
- <20100605033626.GA2252@progeny.tock>
- In-Reply-To
- <AANLkTil541q0RtZsEmnLOtUNxfltvcFCGxpxR-myhyDl@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Sat, Jun 5, 2010 at 02:57, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> This handles builtins. ‘grep PROGRAM_OBJS Makefile’ reveals nine >> other source files with their own main() functions.
[...]
> They're mostly guts, but I guess imap-send should be translated.
Ok, I just wanted to make sure it was intentional.
Is the porcelain/plumbing distinction meant to be honored here? It is possible the right thing to do would be to have run_builtin() call the function that calls setlocale(), if and only if the command has a USE_LOCALE flag set.
The downside: this would make the handle_internal_command table even wider than it already is.
Jonathan