Re: About [PATCH] gitweb: Create a perl module to store gitweb configuration
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jun 3, 2010, 10:23 UTC
- Message-ID
- <201006031223.31675.jnareb@gmail.com>
- In-Reply-To
- <AANLkTin9ZHij7ldIlSHyCqOd8NmU9DQA5q-tyvIImtdD@mail.gmail.com>
On Thu, 3 Jun 2010, Pavan Kumar Sunkarawrote:
Show 5 quoted lines
> 2010/6/3 Jakub Narebski <jnareb@gmail.com>: >> >> This comment is about commit 9526ab8 (gitweb: Create a perl module to >> store gitweb configuration, 2010-06-01) on 'master' branch of >> repository shown at http://repo.or.cz/w/git/gsoc2010-gitweb.git
Show 26 quoted lines
>>> diff --git a/gitweb/Makefile b/gitweb/Makefile >>> index d2584fe..45e176e 100644 >>> --- a/gitweb/Makefile >>> +++ b/gitweb/Makefile >>> @@ -55,6 +55,7 @@ PERL_PATH ?= /usr/bin/perl >>> bindir_SQ = $(subst ','\'',$(bindir))#' >>> gitwebdir_SQ = $(subst ','\'',$(gitwebdir))#' >>> gitwebstaticdir_SQ = $(subst ','\'',$(gitwebdir)/static)#' >>> +gitweblibdir_SQ = $(subst ','\'',$(gitwebdir)/lib)#' >> >> I think it would be good idea to have 'gitweblibdir' as a separate >> variable, alongside 'gitwebdir', and which would default to >> >> gitweblibdir = $(gitwebdir)/lib >> >> to make it possible to install gitweb modules not alongside gitweb, >> but somewhere else, for example together with other Perl modules. >> >> Then you would have: >> >> +gitweblibdir_SQ = $(subst ','\'',$(gitweblibdir))#' > > It's great. > >> But I think this change can be left for a separate commit. It is not >> something terribly important, something blocking accepting the patch.
Actually to really be able to put gitweb packages somewhere else, gitweb.perl should *probably* contain
use lib '++GITWEBLIBDIR++';
Otherwise 'gitweblibdir' would have to be either left default to install packages alingside gitweb.cgi script, or be directory that is in PERL5LIB for web server.
So let's leave it for a later commit.
-- Jakub Narebski Poland