git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] decode file:// and ssh:// URLs

From
Jeff King <peff@peff.net>
Date
May 30, 2010, 05:30 UTC
Message-ID
<20100530053002.GA19219@coredump.intra.peff.net>
In-Reply-To
<20100527105014.GA7865@LK-Perkele-V2.elisa-laajakaista.fi>
On Thu, May 27, 2010 at 01:50:15PM +0300, Ilari Liusvaara wrote:
Show 8 quoted lines
> > With this patch, we will now percent-decode any file:// or
> > ssh:// url (or ssh+git, git+ssh, etc) at the transport
> > layer. We continue to treat plain paths and "host:path"
> > syntax literally.
> 
> One possible fallout: IPv6 scope syntax uses literal '%' in host
> part. The relevant RFC indicates it should be escaped, but in the past
> connect would fail if it was... But then, who uses that syntax...

Bleh. I am not happy about breaking a syntax people might be using, but the current behavior is broken, which will cause problems for some other people. Short of doing some context-sensitive "is this probably a literal % in the host" heuristic (which I really think is a bad idea), I think we will have to break one or the other.

-Peff
Previous: Ilari Liusvaara
Message 6 of 6 in “Bug with URL-decoding”
  1. Dave AbrahamsMay 6, 2010
  2. Jeff KingMay 23, 2010
  3. 1/2 make url-related functions reusableJeff King, May 23, 2010
  4. 2/2 decode file:// and ssh:// URLsJeff King, May 23, 2010
  5. Ilari LiusvaaraMay 27, 2010
  6. Jeff KingMay 30, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.