From: Jeff King <peff@peff.net>
Date: Sun, 30 May 2010 05:30:02 GMT
Subject: Re: [PATCH 2/2] decode file:// and ssh:// URLs
Message-ID: <20100530053002.GA19219@coredump.intra.peff.net>
In-Reply-To: <20100527105014.GA7865@LK-Perkele-V2.elisa-laajakaista.fi>

On Thu, May 27, 2010 at 01:50:15PM +0300, Ilari Liusvaara wrote:

> > With this patch, we will now percent-decode any file:// or
> > ssh:// url (or ssh+git, git+ssh, etc) at the transport
> > layer. We continue to treat plain paths and "host:path"
> > syntax literally.
> 
> One possible fallout: IPv6 scope syntax uses literal '%' in host
> part. The relevant RFC indicates it should be escaped, but in the past
> connect would fail if it was... But then, who uses that syntax...

Bleh. I am not happy about breaking a syntax people might be using, but
the current behavior is broken, which will cause problems for some other
people. Short of doing some context-sensitive "is this probably a
literal % in the host" heuristic (which I really think is a bad idea), I
think we will have to break one or the other.

-Peff