Re: new platform & S_IFGITLINK problem

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 5, 2010, 02:29 UTC
Message-ID: <20100505022907.GA17743@progeny.tock>
In-Reply-To: <1272756555.13488.1314.camel@jetpack.demon.co.uk>

Hi,

Alan Hourihane wrote:

Show 5 quoted lines

> Additionally, attached is a patch that I currently need to apply in
> order to compile git successfully on the FreeMiNT platform (which is
> m68k based).
> 
> Comments appreciated.

While wiser people discuss the hard part, here are some tiny nitpicks. :)

Show 5 quoted lines

> --- /dev/null	2008-12-07 20:01:52.000000000 +0000
> +++ compat/mint.h	2008-12-23 11:52:10.000000000 +0000
> @@ -0,0 +1,2 @@
> +#define SA_RESTART 0
> +#define ss_family sa_family

Does MiNT restart interrupted system calls by default? Are most operations generally not interruptible anyway?

Show 8 quoted lines

> --- Makefile	2009-01-29 12:12:01.000000000 +0000
> +++ Makefile	2009-01-29 12:13:39.000000000 +0000
> @@ -1618,7 +1613,7 @@
>  
>  git-imap-send$X: imap-send.o $(GITLIBS)
>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> -		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
> +		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)

NEEDS_CRYPTO_WITH_SSL = YesPlease

[...]

>  git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)
>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> -		$(LIBS) $(CURL_LIBCURL)
> +		$(LIBS) $(CURL_LIBCURL) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)

[...]

CURL_LIBCURL = -lcurl $(OPENSSL_LIBSSL)

Hope that helps, Jonathan