git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][CLEANUP] remove ecb parameter from xdi_diff_outf()

From
Jeff King <peff@peff.net>
Date
May 4, 2010, 20:58 UTC
Message-ID
<20100504205853.GA10716@coredump.intra.peff.net>
In-Reply-To
<4BE0867E.3060906@lsrfire.ath.cx>
On Tue, May 04, 2010 at 10:41:34PM +0200, René Scharfe wrote:
Show 5 quoted lines
> xdi_diff_outf() overrides the structure members of its last parameter,
> ignoring any value that callers pass in.  It's no surprise then that all
> callers pass a pointer to an uninitialized structure.  They also don't
> read it after the call, so the parameter is neither used for input nor
> for output.   Turn it into a local variable of xdi_diff_outf().
Heh:
  http://article.gmane.org/gmane.comp.version-control.git/102861
So,
Acked-by: Jeff King <peff@peff.net>
-Peff
Previous: René Scharfe
Message 2 of 2 in “[CLEANUP] remove ecb parameter from xdi_diff_outf()”
  1. [CLEANUP] remove ecb parameter from xdi_diff_outf()René Scharfe, May 4, 2010
  2. Jeff KingMay 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.