From: Jeff King <peff@peff.net>
Date: Tue, 04 May 2010 20:58:53 GMT
Subject: Re: [PATCH][CLEANUP] remove ecb parameter from xdi_diff_outf()
Message-ID: <20100504205853.GA10716@coredump.intra.peff.net>
In-Reply-To: <4BE0867E.3060906@lsrfire.ath.cx>

On Tue, May 04, 2010 at 10:41:34PM +0200, René Scharfe wrote:

> xdi_diff_outf() overrides the structure members of its last parameter,
> ignoring any value that callers pass in.  It's no surprise then that all
> callers pass a pointer to an uninitialized structure.  They also don't
> read it after the call, so the parameter is neither used for input nor
> for output.   Turn it into a local variable of xdi_diff_outf().

Heh:

  http://article.gmane.org/gmane.comp.version-control.git/102861

So,

Acked-by: Jeff King <peff@peff.net>

-Peff