Re: [PATCH/RFC 0/2] git-svn: Allow certain refs to be ignored

From: Eric Wong <normalperson@yhbt.net>
Date: Apr 21, 2010, 07:15 UTC
Message-ID: <20100421071505.GA11339@dcvr.yhbt.net>
In-Reply-To: <7vbpddekwk.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Michael Olson <mwolson@gnu.org> writes:
> 
> > [svn-remote "svn"]
> >        url = https://svn.my.org/svn/root
> > ...
> >        ignore-refs = ^refs/remotes/(tags/)?old/myorg
> 
> Traditionally configuration variable names are spelled camelCase without
> dashes.  You probably would want to be consistent.

Configuration variables should definitely be camelCase in examples/documentation (and I even dislike camelCase). No dashes or underscores here.

Show 6 quoted lines

> Also "refs" and any pathname-like things are traditionally matched using
> globs and not regexes.  It is Ok to deviate if you have a strong reason to
> (and I suspect it would make it easier to write "exclude" patterns like
> the above example to allow a regex here), but that needs to be prominently
> documented (e.g. "Unlike any other ref-matching configuration variable,
> this alone uses regex, not glob") to avoid end user confusion.

I favor globs for more consistent/natural for path matching.

Another thing to keep in mind is that these would be Perl regular expressions exposed to a user interface. If git-svn were ever be reimplemented in something other than Perl, PCRE (or similar) would be required to interpret them consistently.

-- 
Eric Wong