git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] git status: refresh the index

From
Jeff King <peff@peff.net>
Date
Apr 2, 2010, 21:21 UTC
Message-ID
<20100402212120.GA28352@coredump.intra.peff.net>
In-Reply-To
<201004022237.04130.markus.heidelberg@web.de>
On Fri, Apr 02, 2010 at 09:37:03PM +0100, Markus Heidelberg wrote:
Show 6 quoted lines
> > Does this mean we will fail to run in a read-only repository?
> 
> You're right.
> But that was already the case when "status" was "commit --dry-run".
> I have to admit, I didn't think about this scenario, but simply looked
> for the differences between these two commands.

Sort of. See ab68545 (status: don't require the repository to be writable, 2010-01-19), which went onto maint while the "status is no longer commit --dry-run" topic was cooking elsewhere. So I think it would be a regression from 1.6.6.2 onwards.

At any rate, I think we all agree on what it _should_ do, so if you're willing to do an updated patch, that would be great. The patch from ab68545 may be helpful, as the code it changed is quite similar to what you posted in this series.

-Peff
Previous: Markus HeidelbergNext: Junio C Hamano
Message 8 of 15 in “fix regression that "git status" doesn't refresh the index”
  1. 0/4 fix regression that "git status" doesn't refresh the indexMarkus Heidelberg, Apr 2, 2010
  2. 1/4 builtin/commit: fix duplicated sentence in a commentMarkus Heidelberg, Apr 2, 2010
  3. 2/4 builtin/commit: remove unnecessary variable definitionMarkus Heidelberg, Apr 2, 2010
  4. 3/4 t7508: add test for "git status" refreshing the indexMarkus Heidelberg, Apr 2, 2010
  5. 4/4 git status: refresh the indexMarkus Heidelberg, Apr 2, 2010
  6. Jeff KingApr 2, 2010
  7. Markus HeidelbergApr 2, 2010
  8. Jeff KingApr 2, 2010
  9. Junio C HamanoApr 2, 2010
  10. Markus HeidelbergApr 2, 2010
  11. 4/4 git status: refresh the index if possibleMarkus Heidelberg, Apr 2, 2010
  12. Junio C HamanoApr 3, 2010
  13. t7508: add a test for "git status" in a read-only repositoryMarkus Heidelberg, Apr 3, 2010
  14. Junio C HamanoApr 6, 2010
  15. Markus HeidelbergApr 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.