git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] git status: refresh the index

From
Markus Heidelberg <markus.heidelberg@web.de>
Date
Apr 2, 2010, 12:27 UTC
Message-ID
<1270211241-10795-5-git-send-email-markus.heidelberg@web.de>
In-Reply-To
<1270211241-10795-1-git-send-email-markus.heidelberg@web.de>

This was already the case before commit 9e4b7ab6 (git status: not "commit --dry-run" anymore, 2009-08-15) and got lost during the conversion, which was meant to only change behaviour when invoked with arguments.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 builtin/commit.c  |    5 +++++
 t/t7508-status.sh |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index c5ab683..2262734 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1017,6 +1017,7 @@ static int git_status_config(const char *k, const char *v, void *cb)
 int cmd_status(int argc, const char **argv, const char *prefix)
 {
 	struct wt_status s;
+	int fd;
 	unsigned char sha1[20];
 	static struct option builtin_status_options[] = {
 		OPT__VERBOSE(&verbose),
@@ -1050,6 +1051,10 @@ int cmd_status(int argc, const char **argv, const char *prefix)
 
 	read_cache_preload(s.pathspec);
 	refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED, s.pathspec, NULL, NULL);
+	fd = hold_locked_index(&index_lock, 1);
+	if (write_cache(fd, active_cache, active_nr) ||
+	    commit_locked_index(&index_lock))
+		die("unable to write new_index file");
 	s.is_initial = get_sha1(s.reference, sha1) ? 1 : 0;
 	s.in_merge = in_merge;
 	wt_status_collect(&s);
diff --git a/t/t7508-status.sh b/t/t7508-status.sh
index 086ec3a..c317bde 100755
--- a/t/t7508-status.sh
+++ b/t/t7508-status.sh
@@ -499,7 +499,7 @@ test_expect_success 'dry-run of partial commit excluding new file in index' '
 cat >expect <<EOF
 :100644 100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0000000000000000000000000000000000000000 M	dir1/modified
 EOF
-test_expect_failure 'status refreshes the index' '
+test_expect_success 'status refreshes the index' '
 	touch dir2/added &&
 	git status &&
 	git diff-files >output &&
-- 
1.7.0.4.300.gc535b
Previous: Markus HeidelbergNext: Jeff King
Message 5 of 15 in “fix regression that "git status" doesn't refresh the index”
  1. 0/4 fix regression that "git status" doesn't refresh the indexMarkus Heidelberg, Apr 2, 2010
  2. 1/4 builtin/commit: fix duplicated sentence in a commentMarkus Heidelberg, Apr 2, 2010
  3. 2/4 builtin/commit: remove unnecessary variable definitionMarkus Heidelberg, Apr 2, 2010
  4. 3/4 t7508: add test for "git status" refreshing the indexMarkus Heidelberg, Apr 2, 2010
  5. 4/4 git status: refresh the indexMarkus Heidelberg, Apr 2, 2010
  6. Jeff KingApr 2, 2010
  7. Markus HeidelbergApr 2, 2010
  8. Jeff KingApr 2, 2010
  9. Junio C HamanoApr 2, 2010
  10. Markus HeidelbergApr 2, 2010
  11. 4/4 git status: refresh the index if possibleMarkus Heidelberg, Apr 2, 2010
  12. Junio C HamanoApr 3, 2010
  13. t7508: add a test for "git status" in a read-only repositoryMarkus Heidelberg, Apr 3, 2010
  14. Junio C HamanoApr 6, 2010
  15. Markus HeidelbergApr 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.