git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv5 4/6] instaweb: add minification awareness

From
EWEric Wong <normalperson@yhbt.net>
Date
Apr 1, 2010, 20:50 UTC
Message-ID
<20100401205006.GA13580@dcvr.yhbt.net>
In-Reply-To
<201004011310.01068.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> wrote:
Show 9 quoted lines
> On Thu, 1 Apr 2010, Mark Rada wrote:
> 
> > This patch will cause git-instaweb to use the minified version of gitweb
> > support files (e.g. CSS and JavaScript) if they were generated.
> 
> I was not sure if git-instaweb should use minified files or not, and
> that is why I didn't add support for this to git-instaweb generation.
> But I forgot that git-instaweb uses gitweb.cgi... which in turn can
> use minified versions of gitweb support files.

It can make distro installation footprints smaller, which would be appreciated.

Show 7 quoted lines
> > Without minification awareness, generating the minified version of
> > gitweb's support files will generate a broken instaweb script since the
> > copy of gitweb.cgi will look for gitweb.min.* which will not exist.
> 
> Good catch!
> > 
> > Signed-off-by: Mark Rada <marada@uwaterloo.ca>
Thanks Jakub and Mark,
Acked-by: Eric Wong <normalperson@yhbt.net>
-- 
Eric Wong
Previous: Jakub Narebski
Message 3 of 3 in “[PATCHv5 4/6] instaweb: add minification awareness”
  1. Mark RadaApr 1, 2010
  2. Jakub NarebskiApr 1, 2010
  3. Eric WongApr 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.