From: Eric Wong Date: Thu, 01 Apr 2010 20:50:06 GMT Subject: Re: [PATCHv5 4/6] instaweb: add minification awareness Message-ID: <20100401205006.GA13580@dcvr.yhbt.net> In-Reply-To: <201004011310.01068.jnareb@gmail.com> Jakub Narebski wrote: > On Thu, 1 Apr 2010, Mark Rada wrote: > > > This patch will cause git-instaweb to use the minified version of gitweb > > support files (e.g. CSS and JavaScript) if they were generated. > > I was not sure if git-instaweb should use minified files or not, and > that is why I didn't add support for this to git-instaweb generation. > But I forgot that git-instaweb uses gitweb.cgi... which in turn can > use minified versions of gitweb support files. It can make distro installation footprints smaller, which would be appreciated. > > Without minification awareness, generating the minified version of > > gitweb's support files will generate a broken instaweb script since the > > copy of gitweb.cgi will look for gitweb.min.* which will not exist. > > Good catch! > > > > Signed-off-by: Mark Rada Thanks Jakub and Mark, Acked-by: Eric Wong -- Eric Wong