Re: Tree with leading '0' modes in 1.7.0.3
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Mar 27, 2010, 01:22 UTC
- Message-ID
- <20100327012211.GD10910@spearce.org>
- In-Reply-To
- <4BAD4A82.5070703@gmail.com>
"Mike.lifeguard" <mike.lifeguard@gmail.com> wrote:
Show 7 quoted lines
> On 10-03-26 08:56 PM, Avery Pennarun wrote: > > The problem is that everything in git works perfectly with these > > invalid file modes *except* fsck, and there's rarely a need to run > > fsck, so this problem can hide for a long time. > > So, does the error matter or not? If it doesn't matter, then shouldn't > Jgit stop whining? If it does, then whatever-it-is needs to be fixed.
Its less harmful than other types of corruption. But its quite wrong from a format perspective. The hash of the tree differs even though there is no semantic difference in the tree content.
Given that GitHub has blessed the world with this corruption, we may need to modify JGit to accept it.
-- Shawn.