Re: [PATCH 1/3] gitk: Avoid calling tk_setPalette on Windows

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 23, 2010, 02:29 UTC
Message-ID: <20100323022903.GA5213@progeny.tock>
In-Reply-To: <87tys8c6ki.fsf@fox.patthoyts.tk>

Pat Thoyts wrote:

>>>  # For some reason, tk_setPalette chooses a nasty dark red for selectColor
>>>  # if we don't specify one ourselves, which makes the checkbuttons and
>>>  # radiobuttons look bad.  This chooses white for selectColor if the
>>>  # background color is light, or black if it is dark.

[...]

Show 8 quoted lines

> This has never been true for Windows which has always used the native
> images for check and radio buttons. So the comment there is relevant
> only to X11. I believe in Tk 8.5 the check/radio buttons now use
> images by default (the ttk versions will look appropriate to the
> current theme - however that may be defined).
> 
> However, messing about with this on X11 would need testing that I
> can't do on Windows. Hence the suggested fix.

Thanks for the pointers. Sp it seems that the “interface color” setting does not have the desired effect when themed widgets are enabled. You can see some screenshots here:

  http://repo.or.cz/w/git/jrn.git/commit/gitk-snapshots

The text fields, buttons, and drop-down boxes retain the traditional grey background, while the menu bar, “SHA1 ID” label, and “Lines of context” selector do change color. The effect is very strange.

When themed widgets are disabled, the tk_setPalette issue described in the comment still applies.

So I can understand better: are you saying in Windows themed widgets are always used?

Jonathan