git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] gitk: Avoid calling tk_setPalette on Windows

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 20, 2010, 06:32 UTC
Message-ID
<20100320063256.GA26519@progeny.tock>
In-Reply-To
<1268418709-4998-1-git-send-email-patthoyts@users.sourceforge.net>
Pat Thoyts wrote:
Show 18 quoted lines
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---
>  gitk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/gitk b/gitk
> index 1f36a3e..dc9b8a8 100755
> --- a/gitk
> +++ b/gitk
> @@ -10845,10 +10845,11 @@ proc setselbg {c} {
>  
>  # This sets the background color and the color scheme for the whole UI.
>  # For some reason, tk_setPalette chooses a nasty dark red for selectColor
>  # if we don't specify one ourselves, which makes the checkbuttons and
>  # radiobuttons look bad.  This chooses white for selectColor if the
>  # background color is light, or black if it is dark.
>  proc setui {c} {
> +    if {[tk windowingsystem] eq "win32"} { return }

Do you know whether the situation described by the comment has been addressed for Tk? Maybe gitk could check for an appropriate Tk version to avoid this workaround on all platforms.

Previous: Jonathan NiederNext: Pat Thoyts
Message 8 of 10 in “gitk: Avoid calling tk_setPalette on Windows”
  1. 1/3 gitk: Avoid calling tk_setPalette on WindowsPat Thoyts, Mar 12, 2010
  2. 2/3 gitk: Add emacs editor variable block.Pat Thoyts, Mar 12, 2010
  3. 3/3 gitk: fix display of copyright symbolPat Thoyts, Mar 12, 2010
  4. gitk: Fix display of copyright symbol in non-utf-8 localesJonathan Nieder, Mar 20, 2010
  5. gitk: Update makefile to keep -encoding option for gitk-wishJonathan Nieder, Mar 20, 2010
  6. Pat ThoytsMar 22, 2010
  7. Jonathan NiederMar 22, 2010
  8. Jonathan NiederMar 20, 2010
  9. Pat ThoytsMar 22, 2010
  10. Jonathan NiederMar 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.