Re: [PATCH 1/3] gitk: Avoid calling tk_setPalette on Windows
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 20, 2010, 06:32 UTC
- Message-ID
- <20100320063256.GA26519@progeny.tock>
- In-Reply-To
- <1268418709-4998-1-git-send-email-patthoyts@users.sourceforge.net>
Pat Thoyts wrote:
Show 18 quoted lines
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---
> gitk | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/gitk b/gitk
> index 1f36a3e..dc9b8a8 100755
> --- a/gitk
> +++ b/gitk
> @@ -10845,10 +10845,11 @@ proc setselbg {c} {
>
> # This sets the background color and the color scheme for the whole UI.
> # For some reason, tk_setPalette chooses a nasty dark red for selectColor
> # if we don't specify one ourselves, which makes the checkbuttons and
> # radiobuttons look bad. This chooses white for selectColor if the
> # background color is light, or black if it is dark.
> proc setui {c} {
> + if {[tk windowingsystem] eq "win32"} { return }Do you know whether the situation described by the comment has been addressed for Tk? Maybe gitk could check for an appropriate Tk version to avoid this workaround on all platforms.