Re: [PATCH 1/5] tag -v: use ‘git verify-tag’ without dash

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 20, 2010, 21:29 UTC
Message-ID: <20100320212932.GA30010@progeny.tock>
In-Reply-To: <201003201701.16820.j6t@kdbg.org>

Johannes Sixt wrote:

> On Samstag, 20. März 2010, Jonathan Nieder wrote:

Show 11 quoted lines

>> -	const char *argv_verify_tag[] = {"git-verify-tag",
>> +	const char *argv_verify_tag[] = {"git", "verify-tag",
>>  					"-v", "SHA1_HEX", NULL};
>> -	argv_verify_tag[2] = sha1_to_hex(sha1);
>> +	argv_verify_tag[3] = sha1_to_hex(sha1);
>>
>>  	if (run_command_v_opt(argv_verify_tag, 0))
>>  		return error("could not verify the tag '%s'", name);
>
> This should rather be changed to run_command_v_opt(..., RUN_GIT_CMD). See 
> other examples in the code.

Neat.  Thanks for the pointer.

> Oh, you remove this in a later patch. Then why have this patch at all?

If the rest of the patches go in the right direction, this one should be dropped. I should presented it as two alternative series instead: one that follows the appropriate calling convention here, and one that libifies verify_tag.

In other words, no good reason at all; thanks for pointing it out. I’ll send a version of patch 4/5 that doesn’t depend on this one in a moment.

Jonathan