Re: [PATCH 1/5] tag -v: use ‘git verify-tag’ without dash
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Mar 20, 2010, 16:01 UTC
- Message-ID
- <201003201701.16820.j6t@kdbg.org>
- In-Reply-To
- <20100320051148.GA24791@progeny.tock>
On Samstag, 20. März 2010, Jonathan Nieder wrote:
Show 8 quoted lines
> - const char *argv_verify_tag[] = {"git-verify-tag",
> + const char *argv_verify_tag[] = {"git", "verify-tag",
> "-v", "SHA1_HEX", NULL};
> - argv_verify_tag[2] = sha1_to_hex(sha1);
> + argv_verify_tag[3] = sha1_to_hex(sha1);
>
> if (run_command_v_opt(argv_verify_tag, 0))
> return error("could not verify the tag '%s'", name);This should rather be changed to run_command_v_opt(..., RUN_GIT_CMD). See other examples in the code.
Oh, you remove this in a later patch. Then why have this patch at all?
-- Hannes