git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add support for GIT_ONE_FILESYSTEM

From
Lars Damerow <lars@pixar.com>
Date
Mar 16, 2010, 05:56 UTC
Message-ID
<20100316055625.GA10907@pixar.com>
In-Reply-To
<7vbpeovqyi.fsf@alter.siamese.dyndns.org>
Show 6 quoted lines
>From Junio C Hamano <gitster@pobox.com>, Mon, Mar 15, 2010 at 09:19:17PM -0700:
> 
> How inefficient is it to repeatedly call getenv() in a loop, by the way?
> I think the patch would become easier to read if env_bool() is called once
> at the beginning to set a local variable, and not even do the initial stat()
> for "." if this feature is not asked for.

Agreed, I didn't do this too efficiently. Thanks for the feedback! I'll make a new patch and resubmit.

cheers, -lars

-- lars r. damerow :: button pusher :: pixar animation studios

When in doubt, use brute force.
Previous: Junio C Hamano
Message 8 of 8 in “Add support for GIT_ONE_FILESYSTEM”
  1. Add support for GIT_ONE_FILESYSTEMLars Damerow, Mar 15, 2010
  2. Sverre RabbelierMar 15, 2010
  3. Lars DamerowMar 15, 2010
  4. Jeff KingMar 16, 2010
  5. Lars DamerowMar 16, 2010
  6. Jeff KingMar 16, 2010
  7. Junio C HamanoMar 16, 2010
  8. Lars DamerowMar 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.