Re: [PATCH] Add support for GIT_ONE_FILESYSTEM

From: Jeff King <peff@peff.net>
Date: Mar 16, 2010, 02:33 UTC
Message-ID: <20100316023306.GA14253@coredump.intra.peff.net>
In-Reply-To: <20100315214003.GB11157@pixar.com>

On Mon, Mar 15, 2010 at 02:40:03PM -0700, Lars Damerow wrote:

> +		if (getenv("GIT_ONE_FILESYSTEM") != NULL) {

Should this really trigger for GIT_ONE_FILESYSTEM=0? We already have git_env_bool, which will handle 0/1, true/false, etc. Probably you should use it here.

I am not a big fan of the environment variable name, either, but I don't have another good suggestion. It is closely related to GIT_CEILING_DIRECTORIES (in fact, you could probably solve the same problem with GIT_CEILING_DIRECTORIES, but I think your solution is much nicer in that it lets the user get away with being less verbose).

Show 5 quoted lines

> +			if (stat("..", &buf))
> +				die_errno("failed to stat '..'");
> +			if (buf.st_dev != current_device)
> +				die("refusing to cross filesystem boundary '%s/..'", cwd);
> +		}

I agree with Sverre that this message isn't descriptive enough, but I like the suggestion you posted elsewhere in the thread.

-Peff