Re: [PATCH 3/3] Revert "git-svn: always initialize with core.autocrlf=false"

From: Eric Wong <normalperson@yhbt.net>
Date: Mar 4, 2010, 09:53 UTC
Message-ID: <20100304095350.GB12885@dcvr.yhbt.net>
In-Reply-To: <40aa078e1003031216l5d164654ta8ff7ea6c8cf2162@mail.gmail.com>

Erik Faye-Lund <kusmabite@googlemail.com> wrote:

Show 10 quoted lines

> On Wed, Mar 3, 2010 at 9:10 PM, Erik Faye-Lund <kusmabite@googlemail.com> wrote:
> > git-svn dcommit uses diff-tree (which does not apply CRLF conversion) to
> > generate SVN commits, so there never were any CRLF conversion issues when
> > commiting in the first place.
> 
> Uhm, this comment is slightly wrong. diff-tree is used to find out if
> there's a change in a file at all. cat_blob(), which in turn uses "git
> cat-file", is used to get the file contents.
> 
> Sorry for the noise.

Hi Erik,

Yes, diff-tree is only used to find changed paths, not the actual content changes. git svn always uses entire blobs from cat-file.

So cat-file won't do CRLF conversions at all, meaning this change is safe for previously created repos, correct? If so, consider patches 2/3 and 3/3 acked by me.

1/3 looks alright, too, but I'll wait for Dmitry as I've never hacked on (builtin-)hash-object.c

-- 
Eric Wong