git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] git-svn: support fetch with autocrlf on

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Mar 3, 2010, 20:10 UTC
Message-ID
<1267647023-2604-2-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1267647023-2604-1-git-send-email-kusmabite@gmail.com>

Before commit d3c9634e, performing a "git svn rebase" that fetched a change containing CRLFs corrupted the git-svn meta-data. This was worked around in d3c9634e by setting core.autocrlf to "false" in the per-repo config when initing the clone. However, if the config variable was later changed, the corruption would still occur.

This patch tries to fix it while allowing core.autocrlf to be enabled, by disabling filters when when hashing.

git-svn is currently the only call-site for hash_and_insert_object (apart from the test-suite), so changing it should be safe.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 perl/Git.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 970fe43..1926dc9 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -842,7 +842,7 @@ sub _open_hash_and_insert_object_if_needed {
 
 	($self->{hash_object_pid}, $self->{hash_object_in},
 	 $self->{hash_object_out}, $self->{hash_object_ctx}) =
-		command_bidi_pipe(qw(hash-object -w --stdin-paths));
+		command_bidi_pipe(qw(hash-object -w --stdin-paths --no-filters));
 }
 
 sub _close_hash_and_insert_object {
-- 
1.7.0.1.141.gc5984a
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 2 of 9 in “hash-object: support --stdin-paths with --no-filters”
  1. 1/3 hash-object: support --stdin-paths with --no-filtersErik Faye-Lund, Mar 3, 2010
  2. 2/3 git-svn: support fetch with autocrlf onErik Faye-Lund, Mar 3, 2010
  3. 3/3 Revert "git-svn: always initialize with core.autocrlf=false"Erik Faye-Lund, Mar 3, 2010
  4. Erik Faye-LundMar 3, 2010
  5. Eric WongMar 4, 2010
  6. Erik Faye-LundMar 4, 2010
  7. Dmitry PotapovMar 4, 2010
  8. Junio C HamanoMar 4, 2010
  9. Eric WongMar 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.