[PATCH 3/4] cherry-pick: format help message as strbuf
- From
Jeff King <peff@peff.net>
- Date
- Feb 11, 2010, 21:07 UTC
- Message-ID
- <20100211210706.GC9066@coredump.intra.peff.net>
- In-Reply-To
- <20100211210445.GA8819@coredump.intra.peff.net>
This gets rid of the fixed-size buffer and an unchecked sprintf. That sprintf is actually OK as the only variable-sized thing put in it is an abbreviated sha1, which is bounded at 40 characters. However, the next patch will change that to something unbounded.
Note that this function now returns an allocated buffer instead of a static one; however, it doesn't matter as the only caller exits immediately.
Signed-off-by: Jeff King <peff@peff.net> --- builtin-revert.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin-revert.c b/builtin-revert.c index 012c646..77e4f4e 100644 --- a/builtin-revert.c +++ b/builtin-revert.c @@ -200,23 +200,23 @@ static void set_author_ident_env(const char *message) static char *help_msg(const unsigned char *sha1) { - static char helpbuf[1024]; + struct strbuf helpbuf = STRBUF_INIT; char *msg = getenv("GIT_CHERRY_PICK_HELP"); if (msg) return msg; - strcpy(helpbuf, " After resolving the conflicts,\n" + strbuf_addstr(&helpbuf, " After resolving the conflicts,\n" "mark the corrected paths with 'git add <paths>' or 'git rm <paths>'\n" "and commit the result."); if (action == CHERRY_PICK) { - sprintf(helpbuf + strlen(helpbuf), + strbuf_addf(&helpbuf, " When committing, use the option '-c %s'\n" "to retain authorship and message.", find_unique_abbrev(sha1, DEFAULT_ABBREV)); } - return helpbuf; + return strbuf_detach(&helpbuf, NULL); } static struct tree *empty_tree(void)
-- 1.7.0.rc2.40.g33ed2.dirty