git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git cherry-pick --continue?

From
Jeff King <peff@peff.net>
Date
Feb 10, 2010, 21:24 UTC
Message-ID
<20100210212408.GB7728@coredump.intra.peff.net>
In-Reply-To
<20100210210419.GA7728@coredump.intra.peff.net>
On Wed, Feb 10, 2010 at 04:04:19PM -0500, Jeff King wrote:
> [1] On the other hand, I usually mistype that as "git am --continue",
> which _does_ make sense, since you are applying a sequence of patches.
> Maybe "am" should support both.

Hmm. I was thinking "am" was the odd man out, but really there are only two sequencer commands that I noted: rebase and am. So you could perhaps argue that rebase should also learn "--resolved". Or am I forgetting one?

I find the patch below convenient. I dunno if anybody else actually cares.

-- >8 --
Subject: [PATCH] am: allow --continue as a synonym for --resolved

Rebase calls this same function "--continue", which means users may be trained to type it. There is no reason to deprecate --resolved (or -r), but adding this synonym is friendly to users.

Signed-off-by: Jeff King <peff@peff.net>
---
 git-am.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index c8b9cbb..88cef39 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -26,6 +26,7 @@ patch-format=   format the patch(es) are in
 reject          pass it through git-apply
 resolvemsg=     override error message when patch failure occurs
 r,resolved      to be used after a patch failure
+continue        synonym for --resolved
 skip            skip the current patch
 abort           restore the original branch and abort the patching operation.
 committer-date-is-author-date    lie about committer date
@@ -318,7 +319,7 @@ do
 		scissors=t ;;
 	--no-scissors)
 		scissors=f ;;
-	-r|--resolved)
+	-r|--resolved|--continue)
 		resolved=t ;;
 	--skip)
 		skip=t ;;
-- 
1.7.0.rc2.22.g0716c.dirty
Previous: Jeff KingNext: Sverre Rabbelier
Message 3 of 22 in “git cherry-pick --continue?”
  1. Sverre RabbelierFeb 10, 2010
  2. Jeff KingFeb 10, 2010
  3. Jeff KingFeb 10, 2010
  4. Sverre RabbelierFeb 10, 2010
  5. Junio C HamanoFeb 10, 2010
  6. Junio C HamanoFeb 10, 2010
  7. Sverre RabbelierFeb 10, 2010
  8. Junio C HamanoFeb 10, 2010
  9. Sverre RabbelierFeb 10, 2010
  10. Jeff KingFeb 11, 2010
  11. 1/4 cherry-pick: rewrap advice messageJeff King, Feb 11, 2010
  12. 2/4 cherry-pick: refactor commit parsing codeJeff King, Feb 11, 2010
  13. 3/4 cherry-pick: format help message as strbufJeff King, Feb 11, 2010
  14. 4/4 cherry-pick: show commit name instead of sha1Jeff King, Feb 11, 2010
  15. Jeff KingFeb 11, 2010
  16. Jay SoffianFeb 11, 2010
  17. Junio C HamanoFeb 11, 2010
  18. Jeff KingFeb 11, 2010
  19. Jeff KingFeb 11, 2010
  20. Junio C HamanoFeb 11, 2010
  21. Jeff KingFeb 11, 2010
  22. SZEDER GáborFeb 12, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.