git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix remote.<remote>.vcs

From
ILIlari Liusvaara <ilari.liusvaara@elisanet.fi>
Date
Jan 27, 2010, 18:59 UTC
Message-ID
<20100127185927.GA22630@Knoppix>
In-Reply-To
<alpine.LNX.2.00.1001271335140.14365@iabervon.org>
On Wed, Jan 27, 2010 at 01:39:00PM -0500, Daniel Barkalow wrote:
Show 10 quoted lines
> On Wed, 27 Jan 2010, Ilari Liusvaara wrote:
> >  
> >  	if (!remote)
> >  		die("No remote provided to transport_get()");
> >  
> >  	ret->remote = remote;
> > +	helper = remote->foreign_vcs;
> 
> Needs to be "helper = remote ? remote->foreign_vcs : NULL", for the same 
> reason that the test below had been "remote && remote->foreign_vcs".
Few lines above that:
     if (!remote)
             die("No remote provided to transport_get()");
-Ilari
Previous: Daniel BarkalowNext: Junio C Hamano
Message 4 of 7 in “Fix remote.<remote>.vcs”
  1. Fix remote.<remote>.vcsIlari Liusvaara, Jan 27, 2010
  2. Sverre RabbelierJan 27, 2010
  3. Daniel BarkalowJan 27, 2010
  4. Ilari LiusvaaraJan 27, 2010
  5. Junio C HamanoJan 27, 2010
  6. Daniel BarkalowJan 27, 2010
  7. Junio C HamanoJan 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.