From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Wed, 27 Jan 2010 18:59:27 GMT
Subject: Re: [PATCH v2] Fix remote.<remote>.vcs
Message-ID: <20100127185927.GA22630@Knoppix>
In-Reply-To: <alpine.LNX.2.00.1001271335140.14365@iabervon.org>

On Wed, Jan 27, 2010 at 01:39:00PM -0500, Daniel Barkalow wrote:
> On Wed, 27 Jan 2010, Ilari Liusvaara wrote:
> >  
> >  	if (!remote)
> >  		die("No remote provided to transport_get()");
> >  
> >  	ret->remote = remote;
> > +	helper = remote->foreign_vcs;
> 
> Needs to be "helper = remote ? remote->foreign_vcs : NULL", for the same 
> reason that the test below had been "remote && remote->foreign_vcs".

Few lines above that:

     if (!remote)
             die("No remote provided to transport_get()");


-Ilari