Re: [PATCH 1/4] Add xmallocz()

From: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Date: Jan 26, 2010, 21:13 UTC
Message-ID: <20100126211347.GA9194@Knoppix>
In-Reply-To: <7vwrz4y4gf.fsf@alter.siamese.dyndns.org>

On Tue, Jan 26, 2010 at 12:52:00PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > I'd rather see the function lose the NUL termination; if that makes the
> > behaviour inconsistent with its name, perhaps it is better to rename the
> > function; perhaps xmalloc1() to denote that it overallocates by one?
> 
> Actually I take that back---all the callers do benefit from the allocator
> giving a buffer that is pre-terminated with NUL.
> 
> We can also lose "buf[size] = 0" from unpack_sha1_rest() patch.

If that line would be next to xmalloc() line, I would have removed it, but because it was beyound loop, I was worried that something might be done to it (and was not in right mood to analyze the logic properly).

And yeah, that nul-termination in xmemdupz is not needed. Oops, missed that.

-Ilari