[PATCH 1/4] Add xmallocz()
- From
- Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
- Date
- Jan 26, 2010, 18:24 UTC
- Message-ID
- <1264530255-4682-2-git-send-email-ilari.liusvaara@elisanet.fi>
- In-Reply-To
- <1264530255-4682-1-git-send-email-ilari.liusvaara@elisanet.fi>
Add routine for allocating NUL-terminated memory block without risking integer overflow in addition of +1 for NUL byte.
Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi> --- git-compat-util.h | 1 + wrapper.c | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h index 620a7c6..a3c4537 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -348,6 +348,7 @@ extern void release_pack_memory(size_t, int); extern char *xstrdup(const char *str); extern void *xmalloc(size_t size); +extern void *xmallocz(size_t size); extern void *xmemdupz(const void *data, size_t len); extern char *xstrndup(const char *str, size_t len); extern void *xrealloc(void *ptr, size_t size); diff --git a/wrapper.c b/wrapper.c index c9be140..dd7b6ee 100644 --- a/wrapper.c +++ b/wrapper.c @@ -34,6 +34,16 @@ void *xmalloc(size_t size) return ret; } +void *xmallocz(size_t size) +{ + void *ret; + if (size + 1 < size) + die("Data too large to fit into virtual memory space."); + ret = xmalloc(size + 1); + ((char*)ret)[size] = 0; + return ret; +} + /* * xmemdupz() allocates (len + 1) bytes of memory, duplicates "len" bytes of * "data" to the allocated memory, zero terminates the allocated memory, @@ -42,7 +52,7 @@ void *xmalloc(size_t size) */ void *xmemdupz(const void *data, size_t len) { - char *p = xmalloc(len + 1); + char *p = xmallocz(len); memcpy(p, data, len); p[len] = '\0'; return p;
-- 1.6.6.1.439.gf06b6