git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] Add xmallocz()

From
ILIlari Liusvaara <ilari.liusvaara@elisanet.fi>
Date
Jan 26, 2010, 18:24 UTC
Message-ID
<1264530255-4682-2-git-send-email-ilari.liusvaara@elisanet.fi>
In-Reply-To
<1264530255-4682-1-git-send-email-ilari.liusvaara@elisanet.fi>

Add routine for allocating NUL-terminated memory block without risking integer overflow in addition of +1 for NUL byte.

Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
---
 git-compat-util.h |    1 +
 wrapper.c         |   12 +++++++++++-
 2 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 620a7c6..a3c4537 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -348,6 +348,7 @@ extern void release_pack_memory(size_t, int);
 
 extern char *xstrdup(const char *str);
 extern void *xmalloc(size_t size);
+extern void *xmallocz(size_t size);
 extern void *xmemdupz(const void *data, size_t len);
 extern char *xstrndup(const char *str, size_t len);
 extern void *xrealloc(void *ptr, size_t size);
diff --git a/wrapper.c b/wrapper.c
index c9be140..dd7b6ee 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -34,6 +34,16 @@ void *xmalloc(size_t size)
 	return ret;
 }
 
+void *xmallocz(size_t size)
+{
+	void *ret;
+	if (size + 1 < size)
+		die("Data too large to fit into virtual memory space.");
+	ret = xmalloc(size + 1);
+	((char*)ret)[size] = 0;
+	return ret;
+}
+
 /*
  * xmemdupz() allocates (len + 1) bytes of memory, duplicates "len" bytes of
  * "data" to the allocated memory, zero terminates the allocated memory,
@@ -42,7 +52,7 @@ void *xmalloc(size_t size)
  */
 void *xmemdupz(const void *data, size_t len)
 {
-	char *p = xmalloc(len + 1);
+	char *p = xmallocz(len);
 	memcpy(p, data, len);
 	p[len] = '\0';
 	return p;
-- 
1.6.6.1.439.gf06b6
Previous: Ilari LiusvaaraNext: Bill Lear
Message 2 of 13 in “Fix various integer overflows”
  1. 0/4 Fix various integer overflowsIlari Liusvaara, Jan 26, 2010
  2. 1/4 Add xmallocz()Ilari Liusvaara, Jan 26, 2010
  3. Bill LearJan 26, 2010
  4. Junio C HamanoJan 26, 2010
  5. Junio C HamanoJan 26, 2010
  6. Ilari LiusvaaraJan 26, 2010
  7. Bill LearJan 26, 2010
  8. 2/4 Fix integer overflow in patch_delta()Ilari Liusvaara, Jan 26, 2010
  9. 3/4 Fix integer overflow in unpack_sha1_rest()Ilari Liusvaara, Jan 26, 2010
  10. 4/4 Fix integer overflow in unpack_compressed_entry()Ilari Liusvaara, Jan 26, 2010
  11. Junio C HamanoJan 26, 2010
  12. Stephen R. van den BergJan 27, 2010
  13. Ilari LiusvaaraJan 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.