Re: [RFC PATCH 10/10] gitweb: Show appropriate "Generating..." page when regenerating cache (WIP)
- From
Petr Baudis <pasky@suse.cz>
- Date
- Jan 25, 2010, 13:02 UTC
- Message-ID
- <20100125130230.GE9553@machine.or.cz>
- In-Reply-To
- <201001251246.40237.jnareb@gmail.com>
On Mon, Jan 25, 2010 at 12:46:39PM +0100, Jakub Narebski wrote:
Show 23 quoted lines
> On Sun, 24 Jan 2010, Petr Baudis wrote: > > I have stupid question, common to both the original patch and this > > RFC. > > > > > [RFC PATCH 10/10] gitweb: Show appropriate "Generating..." page when > > > regenerating cache (WIP) > > > > Just why is a "Generating..." page appropriate? > > > > I have to admit I hate it; can you please at least make it > > configurable? Why is it needed at all? It [...] confuses > > non-interactive HTTP clients [...] > > First, if I understand the code correctly HTTP clients which do not > honor metaredirect (http-equiv refresh) would get page which looks > the following > > <html> > Generating... > </html> > <html> > Gitweb page > </html>
To be clear, I conjectured it confuses non-interactive HTTP clients from one of the TODOs in your patch series - I'm not sure about it myself. :)
Show 9 quoted lines
> Second, gitweb can always check User-Agent header, and serve
> "Generating..." page only to web browsers:
>
> unless (defined $cgi->user_agent() &&
> $cgi->user_agent() =~ /\b(Mozilla|Opera)\b/i) {
> return;
> }
>
> or something like that.I'm not too happy with this. What about Safari? Opera? ELinks? There's a lot of web browsers.
Most of the issues can be worked around, but I'm not sure why to go through all the trouble. I just personally don't see the value in having the placeholder in there at all, to me it is distracting UI even if all the technicalities are put aside.
But if it will be possible to turn this off eventually, it's all your call whether to bother implementing it. :-)
-- Petr "Pasky" Baudis A lot of people have my books on their bookshelves. That's the problem, they need to read them. -- Don Knuth