Re: [PATCH 8/9] gitweb: Convert output to using indirect file handle

From: Jakub Narebski <jnareb@gmail.com>
Date: Jan 16, 2010, 01:14 UTC
Message-ID: <201001160214.58167.jnareb@gmail.com>
In-Reply-To: <7vmy0eoogx.fsf@alter.siamese.dyndns.org>

On Sat, 16 Jan 2010, Junio C Hamano wrote:

Show 11 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > This means replacing
> >
> >   print <something>;
> > by
> >   print {$out} <something>;
> 
> Just out of curiosity, how is this different from
> 
>     print $out <something>;

Actually there is no difference. It doesn't matter one way or other in situations in gitweb.

I have thought however (but I might be mistaken) that "print {$fh} <sth>" is idiomatic Perl.

'perldoc -f print' says:
    Note that if you're storing FILEHANDLES in an array or other expression,
    you will have to use a block returning its value instead:

           print { $files[$i] } "stuff\n";
           print { $OK ? STDOUT : STDERR } "stuff\n";

Also, there is no "," between FILEHANDLE and LIST in "print FILEHANDLE LIST"

-- 
Jakub Narebski
Poland