git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: set GIT_DIR and GIT_WORK_TREE after setup

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jan 24, 2010, 00:03 UTC
Message-ID
<20100124000305.GK12679@spearce.org>
In-Reply-To
<1264291140-16595-1-git-send-email-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:
Show 12 quoted lines
> Rather than juggling with the env var GIT_DIR around the invocation of
> gitk, set it and GIT_WORK_TREE after finishing setup, ensuring that any
> external tool works with the setup we're running with.
> 
> This also allows us to remove a couple of conditionals when running gitk
> or git gui in a submodule, as we know that the variables are present and
> have to be unset and reset before and after the invocation.
> 
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  git-gui.sh |   43 ++++++++++++++++++++-----------------------
>  1 files changed, 20 insertions(+), 23 deletions(-)
Thanks, applied.
-- 
Shawn.
Previous: Giuseppe BilottaNext: Giuseppe Bilotta
Message 8 of 9 in “[PATCHv4 0/5] git-gui: more robust handling of fancy repos”
  1. Giuseppe BilottaJan 23, 2010
  2. 1/5 git-gui: handle non-standard worktree locationsGiuseppe Bilotta, Jan 23, 2010
  3. 2/5 git-gui: handle bare repos correctlyGiuseppe Bilotta, Jan 23, 2010
  4. 3/5 git-gui: work from the .git dirGiuseppe Bilotta, Jan 23, 2010
  5. 4/5 git-gui: set GIT_DIR and GIT_WORK_TREE after setupGiuseppe Bilotta, Jan 23, 2010
  6. Shawn O. PearceJan 23, 2010
  7. git-gui: set GIT_DIR and GIT_WORK_TREE after setupGiuseppe Bilotta, Jan 23, 2010
  8. Shawn O. PearceJan 24, 2010
  9. 5/5 git-gui: update shortcut tools to use _gitworktreeGiuseppe Bilotta, Jan 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.